Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] FC-0001: update api response mock #307

Closed
wants to merge 1 commit into from

Conversation

dyudyunov
Copy link
Contributor

This is a part of openedx/public-engineering#63

Verified Track app was completely removed from the edx platform
along with EnrollmentTrackUserPartition, so the API response was changed.

Relates to openedx/edx-platform#30472

This is a part of openedx/public-engineering#63

Verified Track app was completely removed from the edx platform
along with EnrollmentTrackUserPartition, so API response was changed.
@openedx-webhooks
Copy link

Thanks for the pull request, @dyudyunov! I've created OSPR-6717 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels May 24, 2022
@dyudyunov
Copy link
Contributor Author

@feanil @dianakhuang please check

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #307 (d25962c) into master (ce63f68) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #307   +/-   ##
=======================================
  Coverage   73.34%   73.34%           
=======================================
  Files         102      102           
  Lines        1898     1898           
  Branches      429      429           
=======================================
  Hits         1392     1392           
  Misses        479      479           
  Partials       27       27           
Impacted Files Coverage Δ
...esources/discussions/factories/mockApiResponses.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce63f68...d25962c. Read the comment docs.

@dyudyunov
Copy link
Contributor Author

Closing because PR it required for was closed

@openedx-webhooks
Copy link

@dyudyunov Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

bradenmacdonald pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U rejected
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants