-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace hardcoded edx string in page head #424
feat: replace hardcoded edx string in page head #424
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## open-release/olive.master #424 +/- ##
============================================================
Coverage ? 74.59%
============================================================
Files ? 108
Lines ? 2015
Branches ? 486
============================================================
Hits ? 1503
Misses ? 485
Partials ? 27 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hi @ihor-romaniuk - is this ready for review? |
Hello. Yes, everything is ready. |
Hi @jristau1984! Flagging for your review/merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asked for changes on the equivalent PR to master.
Hi @ihor-romaniuk! Just checking to see if the requested changes have been made and/or that this pull request is ready for review? |
@ihor-romaniuk - friendly check-in on this :) |
427a690
to
cf720d5
Compare
Hi @arbrandes, @kdmccormick Everything was updated and it's ready for review. PR #425 was also updated. |
@arbrandes @kdmccormick @jristau1984 could you please review / merge this if it's good-to-go? Thanks! |
If tCRIL could get the review done today, I can schedule the merge for later today or Monday. |
@arbrandes friendly ping on this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description:
This PR replace the hardcoded
edx
string in the page head with theSITE_NAME
value from the configuration.Related PRs:
PR to the master brunch - #425