Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace hardcoded edx string in page head #424

Conversation

ihor-romaniuk
Copy link
Contributor

@ihor-romaniuk ihor-romaniuk commented Jan 5, 2023

Description:

This PR replace the hardcoded edx string in the page head with the SITE_NAME value from the configuration.

Related PRs:

PR to the master brunch - #425

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 5, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 6, 2023
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (open-release/olive.master@68b71f2). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             open-release/olive.master     #424   +/-   ##
============================================================
  Coverage                             ?   74.59%           
============================================================
  Files                                ?      108           
  Lines                                ?     2015           
  Branches                             ?      486           
============================================================
  Hits                                 ?     1503           
  Misses                               ?      485           
  Partials                             ?       27           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mphilbrick211
Copy link

Hi @ihor-romaniuk - is this ready for review?

@ihor-romaniuk
Copy link
Contributor Author

Hi @ihor-romaniuk - is this ready for review?

Hello. Yes, everything is ready.

@mphilbrick211
Copy link

Hi @jristau1984! Flagging for your review/merge.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked for changes on the equivalent PR to master.

@mphilbrick211 mphilbrick211 added changes requested waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Jan 27, 2023
@mphilbrick211
Copy link

Hi @ihor-romaniuk! Just checking to see if the requested changes have been made and/or that this pull request is ready for review?

@mphilbrick211
Copy link

@ihor-romaniuk - friendly check-in on this :)

@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/feat/replace-hardcoded-edx-string-in-page-head branch from 427a690 to cf720d5 Compare March 2, 2023 18:06
@ihor-romaniuk
Copy link
Contributor Author

Hi @arbrandes, @kdmccormick
All recommendations about ability to obtain site name dynamically were added.
Also, It required localization of overriding ReactDOM.createPortal for allowing portals in jest.

Everything was updated and it's ready for review.

PR #425 was also updated.

@mphilbrick211
Copy link

@arbrandes @kdmccormick @jristau1984 could you please review / merge this if it's good-to-go? Thanks!

@mphilbrick211 mphilbrick211 removed changes requested waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Mar 3, 2023
@jristau1984
Copy link
Contributor

If tCRIL could get the review done today, I can schedule the merge for later today or Monday.

@kdmccormick kdmccormick removed their request for review March 6, 2023 14:20
@mphilbrick211
Copy link

If tCRIL could get the review done today, I can schedule the merge for later today or Monday.

@arbrandes friendly ping on this :)

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@jristau1984 jristau1984 merged commit 80f93fe into openedx:open-release/olive.master Mar 9, 2023
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@ihor-romaniuk ihor-romaniuk deleted the romaniuk/feat/replace-hardcoded-edx-string-in-page-head branch March 13, 2023 15:27
bradenmacdonald pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants