Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace hardcoded logo with logo from configs #426

Conversation

ihor-romaniuk
Copy link
Contributor

Description:

The current implementation of the header component is custom and doesn't use frontend-component-header as it works in all MFEs so we can't make any changes without interfering with the MFE code.
This PR provides the ability to change the header logo via MFE configuration instead of a hardcoded logo.

Related PRs:

PR to the olive brunch - #423

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 5, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 6, 2023
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 74.26% // Head: 74.26% // No change to project coverage 👍

Coverage data is based on head (5d1b53a) compared to base (6a65826).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #426   +/-   ##
=======================================
  Coverage   74.26%   74.26%           
=======================================
  Files         106      106           
  Lines        2067     2067           
  Branches      512      512           
=======================================
  Hits         1535     1535           
  Misses        504      504           
  Partials       28       28           
Impacted Files Coverage Δ
src/studio-header/Header.jsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mphilbrick211
Copy link

hi @ihor-romaniuk! Is this PR ready for review/merge?

@mphilbrick211
Copy link

Hi @ihor-romaniuk - is this pull request ready for merge?

CC: @arbrandes

@mphilbrick211
Copy link

Hi @arbrandes - flagging this as I think it's ready-to-go.

@ihor-romaniuk
Copy link
Contributor Author

@mphilbrick211 Sorry for delay. It's ready for merge.

@mphilbrick211
Copy link

mphilbrick211 commented Mar 3, 2023

Hi @arbrandes and @jristau1984! Flagging this for your review / merge. Thanks!

@jristau1984 jristau1984 merged commit a5bc86e into openedx:master Mar 3, 2023
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@ihor-romaniuk ihor-romaniuk deleted the romaniuk/feat/replace-hardcoded-logo-with-logo-from-config branch March 6, 2023 08:36
bradenmacdonald pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants