Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quince backport] feat!: remove broken transifex and use atlas exclusively #176

Merged

Conversation

arbrandes
Copy link
Contributor

Backport of #164 to quince.master.

…penedx#164)

* feat!: remove broken transifex and use atlas exclusively

* feat: install openedx-atlas
@arbrandes
Copy link
Contributor Author

Without this, overhangio/tutor-mfe#149 won't work in Quince. Objections, @OmarIthawi?

@arbrandes arbrandes requested a review from OmarIthawi November 17, 2023 15:36
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@a4b7b5f). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master     #176   +/-   ##
=============================================================
  Coverage                              ?   83.06%           
=============================================================
  Files                                 ?       46           
  Lines                                 ?      685           
  Branches                              ?      132           
=============================================================
  Hits                                  ?      569           
  Misses                                ?      116           
  Partials                              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@arbrandes arbrandes merged commit 39c18ac into openedx:open-release/quince.master Nov 17, 2023
7 checks passed
@arbrandes arbrandes deleted the backport-atlas branch November 17, 2023 16:27
@OmarIthawi
Copy link
Member

Without this, overhangio/tutor-mfe#149 won't work in Quince. Objections, @OmarIthawi?

That's correct. No objections. I should have pulled this into quince.1 but forgot to do that. Thanks for staying on the top of the nightly, quince.master branches :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants