-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unify font-family with paragon component styles #598
fix: unify font-family with paragon component styles #598
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #598 +/- ##
=======================================
Coverage 92.37% 92.37%
=======================================
Files 169 169
Lines 3450 3450
Branches 898 898
=======================================
Hits 3187 3187
Misses 243 243
Partials 20 20
☔ View full report in Codecov by Sentry. |
Hi @openedx/edx-infinity! Would someone be able to review / merge this for us? Thanks! |
@ihor-romaniuk Please update this PR. |
@awais-ansari PR was updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR LGTM
@itsjeyd @sundasnoreen12 PR was updated from master branch and ready for merge |
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This pull request contains recommendations for fixing custom font-family and make it unified with all MFEs and Paragon components.
All MFEs must have the same default appearance and change them globally via
brand-openedx
component on demand.Related Pull Requests
PR to the open-release/palm.master branch: #596
PR to the open-release/quince.master branch: #597
Screenshots/sandbox (optional):
Merge Checklist
Post-merge Checklist