lock header row and column #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muselesscreator
force-pushed
the
locked_headers_alone
branch
from
3861a91
to
9e0c326
Compare
muselesscreator
requested review from
mattcarter,
nsprenkle,
Andytr1 and
jnlapierre
jansenk
approved these changes
Oct 21, 2020
mattcarter
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Css Update for locked header row
Css update for table component to allow locked header bar. Is not a 100% solution, as there are some eccentricities to tables that are a bit wonky for our 100% desired solution.
Note: this is just the css from PR 144, which had some somewhat unrelated JS changes associated.
JIRA: JIRA-5347
FIY: @edx/masters-devs-gta