Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix loss of field focus after each character for search field #262

Conversation

ihor-romaniuk
Copy link
Contributor

TL;DR - Fixed loss of field focus after each character for the search field.
The cause of the problem is the last requirements upgrade for the paragon package from 14.16.4 to 19.6.0. In the paragon library, the SearchField was significantly changed and currently after every key press it losses the field focus.

FYI: @openedx/content-aurora

@ihor-romaniuk ihor-romaniuk requested a review from a team as a code owner September 12, 2022 12:40
@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 12, 2022
@natabene
Copy link

@ihor-romaniuk Thank you for the contribution. It looks like this is ready for our review, correct?

@ihor-romaniuk
Copy link
Contributor Author

@ihor-romaniuk Thank you for the contribution. It looks like this is ready for our review, correct?

Yes, everything is ready for review.

@arbrandes
Copy link
Contributor

frontend-app-library-authoring has been affected by this issue forever - gonna try this fix there, too. I'll approve once I confirm it fixes it (here and there). Thanks a lot!

@leangseu-edx
Copy link
Contributor

leangseu-edx commented Nov 7, 2022

Hi, thank you for contributing.

May I ask, why is there a change for package-lock.json when package.json isn't? There was a fix a did a while back for this, without the need to change that d55abbe. I will bring this to the team and should be able to approve it later today.

@ihor-romaniuk
Copy link
Contributor Author

ihor-romaniuk commented Nov 23, 2022

Hi, thank you for contributing.

May I ask, why is there a change for package-lock.json when package.json isn't? There was a fix a did a while back for this, without the need to change that d55abbe. I will bring this to the team and should be able to approve it later today.

All checks fell when installing npm and after rebuilding the package-log all checks went through correctly.
And when we run npm install without the 2nd commit (update package-log file), we still have a diff in this file.

@ProductRyan
Copy link

Creating a JIRA ticket for internal tracking:
https://2u-internal.atlassian.net/browse/AU-943

Copy link
Contributor

@muselesscreator muselesscreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muselesscreator
Copy link
Contributor

Thank you for the clean tests :-)

@muselesscreator muselesscreator merged commit 75eeb45 into openedx:open-release/nutmeg.master Dec 5, 2022
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@ihor-romaniuk ihor-romaniuk deleted the romaniuk/fix/fix-entering-search-text branch December 8, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants