-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix loss of field focus after each character for search field #262
fix: fix loss of field focus after each character for search field #262
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@ihor-romaniuk Thank you for the contribution. It looks like this is ready for our review, correct? |
Yes, everything is ready for review. |
frontend-app-library-authoring has been affected by this issue forever - gonna try this fix there, too. I'll approve once I confirm it fixes it (here and there). Thanks a lot! |
Hi, thank you for contributing. May I ask, why is there a change for |
All checks fell when installing npm and after rebuilding the package-log all checks went through correctly. |
Creating a JIRA ticket for internal tracking: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for the clean tests :-) |
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
TL;DR - Fixed loss of field focus after each character for the search field.
The cause of the problem is the last requirements upgrade for the paragon package from
14.16.4
to19.6.0
. In the paragon library, theSearchField
was significantly changed and currently after every key press it losses the field focus.FYI: @openedx/content-aurora