Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use shared browserslist config #273

Closed
wants to merge 2 commits into from

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Oct 5, 2022

Ticket:
Use shared @edx/browserslist-config

  • Removes custom browserslist configuration in favor of using a shared configuration.
  • Removes is-es5 check in CI since ES5 was only needed for IE 11 support which is dropped. The supported browsers defined by the shared configuration all natively support ES6.

This change reduces the resultant asset bundle size.

@Mashal-m Mashal-m requested a review from a team as a code owner October 5, 2022 12:58
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (3a60955) compared to base (03fa143).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #273   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          108       108           
  Lines         1260      1260           
  Branches       248       248           
=========================================
  Hits          1260      1260           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mashal-m
Copy link
Contributor Author

Mashal-m commented Jan 6, 2023

Closing this because these changes are merged now PR

@Mashal-m Mashal-m closed this Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant