Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate off paragon modal deprecated component #275

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Oct 6, 2022

Ticket

Migrate off deprecated Paragon components

Migrate off paragon modal deprecation in EditModal.jsx file

Before

Screenshot 2022-10-06 at 12 28 26 PM

After

Screenshot 2022-10-06 at 6 23 03 PM

@Mashal-m Mashal-m requested a review from a team as a code owner October 6, 2022 13:24
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (aeee2ef) compared to base (03fa143).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #275   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          108       108           
  Lines         1260      1260           
  Branches       248       248           
=========================================
  Hits          1260      1260           
Impacted Files Coverage Δ
src/components/GradesView/EditModal/index.jsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arbrandes arbrandes merged commit 79679c2 into master Nov 30, 2022
@arbrandes arbrandes deleted the mashal-m/paragon-modal-deprecation branch November 30, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants