Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major version upgrade of paragon #300

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Major version upgrade of paragon #300

merged 4 commits into from
Jun 26, 2023

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Jan 6, 2023 •
edited
Loading

Major version upgrade of @edx/paragon

@Mashal-m Mashal-m requested a review from a team as a code owner January 6, 2023 10:51
@codecov
Copy link

codecov bot commented Jan 6, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (39bff6e) 94.93% compared to head (531837a) 94.93%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         139      139           
  Lines        1343     1343           
  Branches      264      264           
=======================================
  Hits         1275     1275           
  Misses         60       60           
  Partials        8        8

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mashal-m Mashal-m mentioned this pull request Jan 6, 2023
Closed
@Mashal-m Mashal-m force-pushed the mashal-m/paragon_version_upgrade20 branch from b49a7c4 to 252a2d8 Compare February 7, 2023 07:23
@Mashal-m Mashal-m force-pushed the mashal-m/paragon_version_upgrade20 branch from 91bfde7 to ebb7dca Compare May 9, 2023 14:57
@Mashal-m Mashal-m force-pushed the mashal-m/paragon_version_upgrade20 branch from ebb7dca to cdbd07b Compare June 1, 2023 09:28
@muselesscreator
Copy link
Contributor

I have no objection to the paragon update, but we don't need react-intl, as we have it imported through frontend-platform

muselesscreator
muselesscreator reviewed Jun 21, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
mattcarter
mattcarter approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Mashal-m Mashal-m merged commit 9a92e39 into master Jun 26, 2023
@Mashal-m Mashal-m deleted the mashal-m/paragon_version_upgrade20 branch June 26, 2023 12:17
@adamstankiewicz
Copy link
Member

@Mashal-m @muselesscreator Heads up that there was one additional step needed for this major upgrade to v20 of Paragon. Per the release notes, Paragon v20 now exposes a paragonMessages array containing the native translations for Paragon components but the paragonMessages are not yet passed to @edx/frontend-platform via the initialize function in this MFE.

[inform] I created a GitHub issue about this follow-up task here: #340

@adamstankiewicz adamstankiewicz mentioned this pull request Jun 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muselesscreator muselesscreator muselesscreator left review comments

@mattcarter mattcarter mattcarter approved these changes

Assignees

@Mashal-m Mashal-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mashal-m @muselesscreator @adamstankiewicz @mattcarter