Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump frontend-platform #356

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi commented Oct 13, 2023

Description

This PR resolves the PUBLIC_PATH configuration issue by upgrading frontend-platform from v5.0.0 to v5.5.4.

TL;DR - [ A short summary of what this PR does and why ]

JIRA: JIRA-XXXX

What changed?

  • [ More in depth breakdown of changes ]
  • [ Peripheral things that got changed ]
  • [ etc... ]

Developer Checklist

  • Test suites passing
  • Documentation and test plan updated, if applicable
  • Received code-owner approving review
  • Bumped version number package.json

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi requested a review from a team as a code owner October 13, 2023 06:05
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/bump-frontend-platform branch from 932d39f to ecf6b0b Compare October 13, 2023 06:09
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi changed the title bump: chore frontend-platform chore: bump frontend-platform Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (247e9f3) 94.98% compared to head (02c0e52) 94.98%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files         140      140           
  Lines        1357     1357           
  Branches      264      264           
=======================================
  Hits         1289     1289           
  Misses         60       60           
  Partials        8        8           
Files Coverage Δ
...mponents/GradesView/GradebookTable/GradeButton.jsx 100.00% <100.00%> (ø)
src/components/GradesView/GradebookTable/hooks.jsx 100.00% <ø> (ø)
src/data/thunkActions/roles.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/bump-frontend-platform branch from ecf6b0b to 02c0e52 Compare October 16, 2023 07:13
@abdullahwaheed abdullahwaheed merged commit d46ce00 into master Oct 16, 2023
5 checks passed
@abdullahwaheed abdullahwaheed deleted the Ali-Abbas/bump-frontend-platform branch October 16, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants