fix: clean code

remove dashboard from getLearnerHeaderMenu to cleane the code
openedx · Jul 25, 2024 · 69f813c · 69f813c
1 parent eddb511
commit 69f813c
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 19 deletions.
diff --git a/src/containers/LearnerDashboardHeader/LearnerDashboardMenu.jsx b/src/containers/LearnerDashboardHeader/LearnerDashboardMenu.jsx
@@ -8,7 +8,6 @@ const getLearnerHeaderMenu = (
   formatMessage,
   courseSearchUrl,
   authenticatedUser,
-  dashboard,
   exploreCoursesClick,
 ) => ({
   mainMenu: [

diff --git a/src/containers/LearnerDashboardHeader/__snapshots__/index.test.jsx.snap b/src/containers/LearnerDashboardHeader/__snapshots__/index.test.jsx.snap
@@ -5,19 +5,19 @@ exports[`LearnerDashboardHeader render 1`] = `
   <ConfirmEmailBanner />
   <injectIntl(ShimmedIntlComponent)
     mainMenuItems={
-      Array [
-        Object {
+      [
+        {
           "content": "Courses",
           "href": "/",
           "isActive": true,
           "type": "item",
         },
-        Object {
+        {
           "content": "Programs",
           "href": "http://localhost:18000/dashboard/programs",
           "type": "item",
         },
-        Object {
+        {
           "content": "Discover New",
           "href": "undefined",
           "onClick": [Function],
@@ -26,35 +26,35 @@ exports[`LearnerDashboardHeader render 1`] = `
       ]
     }
     secondaryMenuItems={
-      Array [
-        Object {
+      [
+        {
           "content": "Help",
           "href": "http://localhost:18000/support",
           "type": "item",
         },
       ]
     }
     userMenuItems={
-      Array [
-        Object {
+      [
+        {
           "heading": "",
-          "items": Array [
-            Object {
+          "items": [
+            {
               "content": "Profile",
               "href": "http://account-profile-url.test/u/undefined",
               "type": "item",
             },
-            Object {
+            {
               "content": "Account",
               "href": "http://account-settings-url.test",
               "type": "item",
             },
           ],
         },
-        Object {
+        {
           "heading": "",
-          "items": Array [
-            Object {
+          "items": [
+            {
               "content": "Sign Out",
               "href": "http://localhost:18000/logout",
               "type": "item",

diff --git a/src/containers/LearnerDashboardHeader/hooks.js b/src/containers/LearnerDashboardHeader/hooks.js
@@ -28,10 +28,10 @@ export const findCoursesNavDropdownClicked = (href) => track.findCourses.findCou
 });
 
 export const useLearnerDashboardHeaderMenu = ({
-  courseSearchUrl, authenticatedUser, dashboard, exploreCoursesClick,
+  courseSearchUrl, authenticatedUser, exploreCoursesClick,
 }) => {
   const { formatMessage } = useIntl();
-  return getLearnerHeaderMenu(formatMessage, courseSearchUrl, authenticatedUser, dashboard, exploreCoursesClick);
+  return getLearnerHeaderMenu(formatMessage, courseSearchUrl, authenticatedUser, exploreCoursesClick);
 };
 
 export const useLearnerDashboardHeaderData = () => {

diff --git a/src/containers/LearnerDashboardHeader/index.jsx b/src/containers/LearnerDashboardHeader/index.jsx
@@ -15,7 +15,6 @@ import './index.scss';
 export const LearnerDashboardHeader = () => {
   const { authenticatedUser } = React.useContext(AppContext);
   const { courseSearchUrl } = reduxHooks.usePlatformSettingsData();
-  const dashboard = reduxHooks.useEnterpriseDashboardData();
 
   const exploreCoursesClick = findCoursesNavClicked(
     urls.baseAppUrl(courseSearchUrl),
@@ -24,7 +23,6 @@ export const LearnerDashboardHeader = () => {
   const learnerHomeHeaderMenu = useLearnerDashboardHeaderMenu({
     courseSearchUrl,
     authenticatedUser,
-    dashboard,
     exploreCoursesClick,
   });