Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Switch to ubuntu-latest for builds #454

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Sep 9, 2024

This code does not have any dependencies that are specific to any specific
version of ubuntu. So instead of testing on a specific version and then needing
to do work to keep the versions up-to-date, we switch to the ubuntu-latest
target which should be sufficient for testing purposes.

This work is being done as a part of openedx/platform-roadmap#377

closes #420

This code does not have any dependencies that are specific to any specific
version of ubuntu.  So instead of testing on a specific version and then needing
to do work to keep the versions up-to-date, we switch to the ubuntu-latest
target which should be sufficient for testing purposes.

This work is being done as a part of openedx/platform-roadmap#377

closes #420
@feanil feanil requested a review from a team as a code owner September 9, 2024 14:00
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.24%. Comparing base (0cfebb6) to head (ed7a3ff).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   97.24%   97.24%           
=======================================
  Files         154      154           
  Lines        1378     1378           
  Branches      228      229    +1     
=======================================
  Hits         1340     1340           
  Misses         36       36           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinhynes
Copy link
Contributor

justinhynes commented Sep 9, 2024

I'm on call for Aperture this week and will ensure it gets reviewed soon.

Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll go ahead and merge afterwards too. Thanks again!

@justinhynes justinhynes merged commit b4b3d07 into master Sep 9, 2024
7 checks passed
@justinhynes justinhynes deleted the feanil/ubuntu_upgrade branch September 9, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Test frontend-app-learner-dashboard on Ubuntu 24.04
2 participants