Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove Zendesk component from App #455

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

jsnwesson
Copy link
Contributor

APER-3671
Contributes to #255

This PR removes the automatic use of the ZendeskFab component from the App level. The ZendeskFab logic still lives in the src/components directory.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.24%. Comparing base (b4b3d07) to head (63b6657).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #455   +/-   ##
=======================================
  Coverage   97.24%   97.24%           
=======================================
  Files         154      154           
  Lines        1378     1378           
  Branches      228      228           
=======================================
  Hits         1340     1340           
  Misses         36       36           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsnwesson jsnwesson marked this pull request as ready for review September 13, 2024 04:15
@jsnwesson jsnwesson requested a review from a team as a code owner September 13, 2024 04:15
@jsnwesson jsnwesson merged commit 2f8ff3b into master Sep 13, 2024
7 checks passed
@jsnwesson jsnwesson deleted the jwesson/remove-zendesk-core branch September 13, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants