feat: subsidy box points to learner credit #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameenfatima78
force-pushed
the
sameen/ENT-7388
branch
from
7d6f634
to
8d64e38
Compare
sameenfatima78
requested review from
muhammad-ammar,
saleem-latif,
zamanafzal,
irfanuddinahmad and
jajjibhai008
saleem-latif
approved these changes
Aug 24, 2023
sameenfatima78
force-pushed
the
sameen/ENT-7388
branch
2 times, most recently
from
01ece75
to
512b2db
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #810 +/- ##
==========================================
+ Coverage 84.87% 85.02% +0.15%
==========================================
Files 320 324 +4
Lines 6399 6671 +272
Branches 1552 1615 +63
==========================================
+ Hits 5431 5672 +241
- Misses 941 968 +27
- Partials 27 31 +4
☔ View full report in Codecov by Sentry. |
sameenfatima78
force-pushed
the
sameen/ENT-7388
branch
from
512b2db
to
3874186
Compare
|
@adamstankiewicz Hi, I have incorporated all your feedback. Can you please take another look? |
adamstankiewicz
approved these changes
Sep 11, 2023
sameenfatima78
force-pushed
the
sameen/ENT-7388
branch
from
3874186
to
0c9031b
Compare
added tests added more tests minor fixes incorporated feedback incorporated feedback round 2 minor change in the test
sameenfatima78
force-pushed
the
sameen/ENT-7388
branch
from
0c9031b
to
73ad5ac
Compare
adamstankiewicz
added a commit
that referenced
this pull request
Sep 15, 2023
This reverts commit 3637bed.
3 tasks
adamstankiewicz
added a commit
that referenced
this pull request
Sep 15, 2023
sameenfatima78
added a commit
that referenced
this pull request
Sep 18, 2023
sameenfatima78
added a commit
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes
Only if submitting a visual change