Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragon StatusAlert deprecation #248

Merged

Conversation

abdullahwaheed
Copy link
Contributor

@abdullahwaheed abdullahwaheed commented Jun 21, 2022

Ticket

Migrate off deprecated Paragon components

What has changed

Removed deprecated StatusAlert component of paragon and updated it with Alert

References

Paragon StatusAlert
Paragon Alert

@abdullahwaheed abdullahwaheed requested a review from a team June 21, 2022 09:12
@abdullahwaheed abdullahwaheed self-assigned this Jun 21, 2022
@abdullahwaheed abdullahwaheed force-pushed the abdullahwaheed/paragon-status-alert-deprecation branch from c7c2f0f to 4b18087 Compare June 21, 2022 09:23
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #248 (f7f2edb) into master (8ad2cc4) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   67.13%   67.13%           
=======================================
  Files          42       42           
  Lines         782      782           
  Branches      154      154           
=======================================
  Hits          525      525           
  Misses        249      249           
  Partials        8        8           
Impacted Files Coverage Δ
...course-cards/email-settings/EmailSettingsModal.jsx 83.33% <0.00%> (ø)
...omponents/course-enrollments/CourseEnrollments.jsx 80.43% <100.00%> (ø)
src/components/programs-list/ProgramListPage.jsx 94.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abdullahwaheed abdullahwaheed force-pushed the abdullahwaheed/paragon-status-alert-deprecation branch from 783e18b to 69ab6df Compare June 21, 2022 10:35
Copy link

@davidjoy davidjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fine change - the owning team should also review so they're aware of the change, it should be tested by Fed-BOM and we can get it in. I did a cursory review.

Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Let's merge. Then I can help you test on the stage environment.

@jmbowman jmbowman added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jul 25, 2022
@abdullahwaheed abdullahwaheed merged commit 6f265b8 into master Aug 11, 2022
@abdullahwaheed abdullahwaheed deleted the abdullahwaheed/paragon-status-alert-deprecation branch August 11, 2022 05:30
@jmbowman jmbowman removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants