Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @testing-library/react to v14 #280

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 12, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@testing-library/react 12.1.5 -> 14.2.2 age adoption passing confidence

Release Notes

testing-library/react-testing-library (@​testing-library/react)

v14.2.2

Compare Source

v14.2.1

Compare Source

Bug Fixes
  • Update types to support all possible react component return values (#​1272) (55e79c2)

v14.2.0

Compare Source

Features
  • add reactStrictMode option to enable strict mode render (#​1241) (0880eba)

v14.1.2

Compare Source

Bug Fixes

v14.1.1

Compare Source

Bug Fixes

v14.1.0

Compare Source

Features

v14.0.0

Compare Source

Bug Fixes
Features
BREAKING CHANGES

v13.4.0

Compare Source

Features
  • renderHook: allow passing of all render options to renderHook (#​1118) (27a9584)

v13.3.0

Compare Source

Features

v13.2.0

Compare Source

Features

v13.1.1

Compare Source

Bug Fixes

v13.1.0

Compare Source

Features

v13.0.1

Compare Source

Bug Fixes

v13.0.0

Compare Source

Features
BREAKING CHANGES

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link
Contributor Author

renovate bot commented Feb 12, 2024

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: @edx/frontend-app-learner-record@0.1.0
npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"17.0.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^18.0.0" from @testing-library/react@14.2.2
npm ERR! node_modules/@testing-library/react
npm ERR!   dev @testing-library/react@"14.2.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2024-03-29T18_10_41_747Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-03-29T18_10_41_747Z-debug-0.log

@renovate renovate bot force-pushed the renovate/testing-library-react-14.x branch 6 times, most recently from 2c9c57d to 50a993b Compare February 16, 2024 18:41
@jsnwesson jsnwesson added the blocked by other work PR cannot be finished until other work is complete label Feb 16, 2024
@jsnwesson
Copy link
Contributor

jsnwesson commented Feb 16, 2024

From my understanding, there are a couple of things blocking this from moving forward:

  1. This dependency requires react and react-dom to be on v18+ (currently at v17)
  2. frontend-build, frontend-platform, frontend-component-header, frontend-component-footer, and paragon will all need to have their peer-dependency expanded to accept v18 of react and react-dom. (reference)
  3. Learner Record will need to update its NPM scope of the above-mentioned deps from @edx to @openedx in order to receive the changes needed in step 2. (PR exists and is being reviewed)

@renovate renovate bot force-pushed the renovate/testing-library-react-14.x branch 5 times, most recently from 8dc5dc7 to 8e9243a Compare February 23, 2024 18:37
@renovate renovate bot force-pushed the renovate/testing-library-react-14.x branch 4 times, most recently from 9d7827f to 15cecee Compare February 28, 2024 17:04
@renovate renovate bot force-pushed the renovate/testing-library-react-14.x branch 3 times, most recently from ef4fcc1 to 9fd0590 Compare March 8, 2024 13:52
@jsnwesson jsnwesson removed the blocked by other work PR cannot be finished until other work is complete label Mar 8, 2024
@renovate renovate bot force-pushed the renovate/testing-library-react-14.x branch 2 times, most recently from 6cc1d21 to 3535faa Compare March 11, 2024 11:19
@renovate renovate bot force-pushed the renovate/testing-library-react-14.x branch 4 times, most recently from 2f7d8f4 to 7953ef0 Compare March 18, 2024 17:52
@jsnwesson jsnwesson added the blocked by other work PR cannot be finished until other work is complete label Mar 18, 2024
@renovate renovate bot force-pushed the renovate/testing-library-react-14.x branch 6 times, most recently from 575eae1 to e3cf4eb Compare March 25, 2024 18:04
@renovate renovate bot enabled auto-merge (rebase) March 29, 2024 11:47
@renovate renovate bot force-pushed the renovate/testing-library-react-14.x branch 2 times, most recently from 264c34f to 481b15d Compare March 29, 2024 11:51
@renovate renovate bot force-pushed the renovate/testing-library-react-14.x branch from 481b15d to f89e16b Compare March 29, 2024 18:10
@renovate renovate bot merged commit 38e0f7a into master Mar 29, 2024
2 of 5 checks passed
@renovate renovate bot deleted the renovate/testing-library-react-14.x branch March 29, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked by other work PR cannot be finished until other work is complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant