Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional xblocks #1296

Conversation

DanielVZ96
Copy link

@DanielVZ96 DanielVZ96 commented Feb 22, 2024

Description

This PR implements separating optional progress from normal progress, and also displaying optional chapters and sequences in the outline.

Testing instructions

follow the instructions from this PR: openedx/edx-platform#34275

Private-ref: BB-8586

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 22, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @DanielVZ96! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@DanielVZ96 DanielVZ96 force-pushed the dvz/optional-completions branch 2 times, most recently from d468023 to 229ffb5 Compare February 22, 2024 04:07
@DanielVZ96 DanielVZ96 force-pushed the dvz/optional-completions branch 3 times, most recently from 0d5b2d7 to 10f4f16 Compare February 25, 2024 06:02
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (open-release/palm.master@21698b4). Click here to learn what that means.

Files Patch % Lines
...ess-tab/course-completion/CompletionDonutChart.jsx 87.50% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##             open-release/palm.master    #1296   +/-   ##
===========================================================
  Coverage                            ?   86.96%           
===========================================================
  Files                               ?      253           
  Lines                               ?     4379           
  Branches                            ?     1113           
===========================================================
  Hits                                ?     3808           
  Misses                              ?      552           
  Partials                            ?       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Agrendalath
Copy link
Member

@DanielVZ96, same note as here.

@openedx-webhooks
Copy link

@DanielVZ96 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants