Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react & react-dom to v17 #190

Merged
merged 14 commits into from
Aug 28, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jun 9, 2023

Ticket

Upgrade React JS to v17

Description

  • Updated react & react-dom to v17 along with testing-library/react & react-test-renderer to respective compatible versions
  • Since Enzyme does not provide support React 17 (enzymejs/enzyme#2429) or 18 (enzymejs/enzyme#2524) itself we switched to community-supported project that aim to provide compatibility between Enzyme and React 17, replacing enzyme-adapter-react-16 with @wojtekmaj/enzyme-adapter-react-17
  • Updated edx packages @edx/frontend-platform, @edx/frontend-component-header, @edx/frontend-component-footer

@Mashal-m Mashal-m force-pushed the bilalqamar95/react-upgrade-to-v17 branch from 9f3d870 to 517522e Compare June 14, 2023 13:33
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7bb31a9) 100.00% compared to head (80b22b3) 100.00%.
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #190   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines         1079      1079           
  Branches       159       159           
=========================================
  Hits          1079      1079           
Files Changed Coverage Δ
src/data/redux/thunkActions/app.js 100.00% <ø> (ø)
src/data/redux/thunkActions/download.js 100.00% <ø> (ø)
src/data/redux/thunkActions/grading.js 100.00% <ø> (ø)
src/data/redux/thunkActions/requests.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m marked this pull request as ready for review July 5, 2023 11:49
@Mashal-m Mashal-m force-pushed the bilalqamar95/react-upgrade-to-v17 branch from 0c1fc01 to e9d5d2e Compare July 12, 2023 14:05
Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@mattcarter mattcarter merged commit b7b9453 into master Aug 28, 2023
5 checks passed
@mattcarter mattcarter deleted the bilalqamar95/react-upgrade-to-v17 branch August 28, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants