Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragon form component deprecations #596

Merged
merged 5 commits into from
Aug 18, 2022

Conversation

abdullahwaheed
Copy link
Contributor

Ticket

Migrate off deprecated Paragon components

What has changed

Updated deprecated ValidationFormGroup to Form.Group, Input to Form.Control and Checkbox to Form. CheckBox.
Tested on edx.org theme.

Screenshots

image

image

@abdullahwaheed abdullahwaheed requested a review from a team August 3, 2022 05:56
@abdullahwaheed abdullahwaheed self-assigned this Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #596 (2627730) into master (8363307) will increase coverage by 0.35%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
+ Coverage   64.61%   64.96%   +0.35%     
==========================================
  Files          45       45              
  Lines         797      805       +8     
  Branches      148      156       +8     
==========================================
+ Hits          515      523       +8     
  Misses        272      272              
  Partials       10       10              
Impacted Files Coverage Δ
src/profile/forms/Bio.jsx 56.52% <100.00%> (+4.14%) ⬆️
src/profile/forms/Country.jsx 58.33% <100.00%> (+3.78%) ⬆️
src/profile/forms/Education.jsx 58.33% <100.00%> (+3.78%) ⬆️
src/profile/forms/PreferredLanguage.jsx 48.38% <100.00%> (+3.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abdullahwaheed abdullahwaheed merged commit 7503e6c into master Aug 18, 2022
@abdullahwaheed abdullahwaheed deleted the abdullahwaheed/paragon-form-deprecations branch August 18, 2022 05:41
snglth pushed a commit to Abstract-Tech/community-theme-profile that referenced this pull request Jul 12, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Michael Terry <mterry@edx.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants