feat: hide 2U specific fields #797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbrandes
requested changes
Nov 22, 2022
36 tasks
Few 2U specific fields are appearing for all types of the course(s) which is creating confusion for the partners.Due to this change, 2U fields would only be displayed for 2U courses PROD-3032
uzairr
force-pushed
the
hide-2u-specific-fields
branch
from
801ab61 to
a9aa6fb
Compare
Ali-D-Akbar
approved these changes
Nov 23, 2022
AliAdnanSohail
approved these changes
Nov 23, 2022
arbrandes
requested changes
Nov 23, 2022
| @@ -226,6 +227,10 @@ export class BaseEditCourseForm extends React.Component { | |||
| this.setCollapsible(true); | |||
| } | |||
|
|
|||
| filterCourseTypes2U(courseType) { | |||
There was a problem hiding this comment.
If we remove "2U" from the object and parameter names we can avoid confusion in the future, making this a truly generic feature.
Suggested change
| filterCourseTypes2U(courseType) { | |
| filterCourseTypes(courseType) { |
| @@ -306,6 +311,7 @@ export class BaseEditCourseForm extends React.Component { | |||
| priceLabels, | |||
| runTypeModes, | |||
| } = parsedTypeOptions; | |||
| const courseTypes2U = courseTypeOptions.filter(this.filterCourseTypes2U); | |||
There was a problem hiding this comment.
Suggested change
| const courseTypes2U = courseTypeOptions.filter(this.filterCourseTypes2U); | |
| const courseTypesToFilter = courseTypeOptions.filter(this.filterCourseTypes); |
| <FieldLabel | ||
| id="organization_logo_override.label" | ||
| text="Organization Logo Override" | ||
| {courseTypes2U?.length > 0 && ( |
There was a problem hiding this comment.
Suggested change
| {courseTypes2U?.length > 0 && ( | |
| {courseTypesToFilter?.length > 0 && ( |
| @@ -1,4 +1,5 @@ | |||
| NODE_ENV='production' | |||
| IDENTIFIER_2U='2U' | |||
There was a problem hiding this comment.
Let's rename this as well, and remove the "2U" default setting which does not make sense for all use cases.
Suggested change
| IDENTIFIER_2U='2U' | |
| COURSE_TYPE_FILTER='' |
| @@ -1,4 +1,5 @@ | |||
| NODE_ENV='development' | |||
| IDENTIFIER_2U='2U' | |||
There was a problem hiding this comment.
Suggested change
| IDENTIFIER_2U='2U' | |
| COURSE_TYPE_FILTER='' |
| @@ -226,6 +227,10 @@ export class BaseEditCourseForm extends React.Component { | |||
| this.setCollapsible(true); | |||
| } | |||
|
|
|||
| filterCourseTypes2U(courseType) { | |||
| return courseType.label.includes(getConfig().IDENTIFIER_2U); | |||
There was a problem hiding this comment.
Suggested change
| return courseType.label.includes(getConfig().IDENTIFIER_2U); | |
| return courseType.label.includes(getConfig().COURSE_TYPE_FILTER); |
| @@ -5,3 +5,4 @@ LOGO_TRADEMARK_URL=https://edx-cdn.org/v3/default/logo-trademark.svg | |||
| LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg | |||
| FAVICON_URL=https://edx-cdn.org/v3/default/favicon.ico | |||
| SITE_NAME='edX' | |||
| IDENTIFIER_2U='2U' | |||
There was a problem hiding this comment.
Suggested change
| IDENTIFIER_2U='2U' | |
| COURSE_TYPE_FILTER='' |
ansabgillani
approved these changes
Nov 23, 2022
28 tasks
22 tasks
44 tasks
22 tasks
This was referenced Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few 2U specific fields are appearing for all types of the course(s) which is creating confusion for the partners.Due to this change, 2U fields would only be displayed for 2U courses
PROD-3032