Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds budget distribution mode selection component in provisioning tool #366

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Nov 30, 2023

Description

With the addition of a top-down assignment option to a policy, modifications are required in the provisioning tool. This involves adding a new form field for budget distribution mode selection during the plan creation step for single and dual budgets. Modify the progressive disclosure logic to show the learner spend limit question only if 'Learner selects content or LMS' is selected. If the user selects 'Admin selects content', hide the learner spend limit question.

JIRA Ticket

UI

Screen.Recording.2023-11-29.at.9.46.10.PM.mov

@katrinan029 katrinan029 marked this pull request as ready for review November 30, 2023 03:11
@katrinan029 katrinan029 changed the title feat: add policy type selection feat: adds budget distribution mode selection component in provisioning tool Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (895ac85) 88.41% compared to head (622581f) 88.34%.

❗ Current head 622581f differs from pull request most recent head 6bc906a. Consider uploading reports for the commit 6bc906a to get more accurate results

Files Patch % Lines
...ningForm/PolicyForm/ProvisioningFormPolicyType.jsx 78.26% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage   88.41%   88.34%   -0.07%     
==========================================
  Files         161      162       +1     
  Lines        3417     3442      +25     
  Branches      841      846       +5     
==========================================
+ Hits         3021     3041      +20     
- Misses        393      398       +5     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 merged commit 6edeec1 into master Dec 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants