-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update learner credit plan cards to use subsidies #419
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #419 +/- ##
==========================================
- Coverage 84.40% 84.38% -0.02%
==========================================
Files 185 185
Lines 3840 3848 +8
Branches 943 937 -6
==========================================
+ Hits 3241 3247 +6
- Misses 576 578 +2
Partials 23 23 ☔ View full report in Codecov by Sentry. |
6468b1c
to
6199fc8
Compare
6199fc8
to
50ced6a
Compare
LICENSE_MANAGER_URL='http://localhost:18170' | ||
LICENSE_MANAGER_DJANGO_URL='http://localhost:18170' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a need for a new LICENSE_MANAGER_DJANGO_URL
variable if the value is the same as the existing LICENSE_MANAGER_URL
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the LICENSE_MANAGER_URL
variable is use for fetching subscriptions data and the LICENSE_MANAGER_DJANGO_URL
is used as the django admin url. we ran into an issue with fetching the data when we used the same url. the fetching one should be license-manager.edx.org
and the admin django screen is license-manager-internal.edx.org
.
Description
Test plan
knguyen2/ent-9476
webpack.dev.config.js
with the following content:.env.development
with this info:npm run start
https://2u-internal.atlassian.net/browse/ENT-9476