Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding link to user page to icon #431

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Sep 30, 2024

Screen.Recording.2024-09-30.at.2.20.38.PM.mov

Jira

Testing:

  • Checkout branch kiram15/ENT-9551 and run npm run start
  • Navigate to https://localhost.stage.edx.org:18450/enterprise-configuration/customers/02982884-1f1f-4103-b6d7-3a602c1afcbd/view and scroll down to member details
  • Hover over both a pending user (no name, just email, should not show any cursor change) and a regular user (should have cursor change)
  • Click on non-pending user to ensure it goes to https://localhost.stage.edx.org:18450/learner_information/?email=LEARNER_EMAIL

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.33%. Comparing base (5ae8cec) to head (fce8aff).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   84.31%   84.33%   +0.02%     
==========================================
  Files         185      185              
  Lines        3850     3855       +5     
  Branches      943      954      +11     
==========================================
+ Hits         3246     3251       +5     
  Misses        581      581              
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@katrinan029 katrinan029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I just have one minor feedback before merging.

const memberDetailIcon = () => {
if (user) {
return (
<Hyperlink destination={iconLink} key={user?.email} data-testId="icon-hyperlink">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have this open to a new tab with target="_blank" and showLaunchIcon={false}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants