Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: variable name for the accessibility link #406

Merged

Conversation

KristinAoki
Copy link
Member

This PR changes the env variable that is required for to show the accessibility page link in the footer. The variable name needed to change because it was not found in the course authoring env config. All the env variable values for the footer are inherited from its parent.

Testing

  1. Add a local version of this repo to your frontend-app-course-authoring/module.config.js file
{ moduleName: '@edx/frontend-component-footer', dir: '../frontend-component-footer', dist: 'dist' },
  1. Navigate to a page in studio that uses the frontend-app-course-authoring
  2. Should not see "Accessibility Accommodation Request" in the footer
  3. In frontend-app-course-authoring/env.dev, update ENABLE_ACCESSIBILITY_PAGE and restart npm
  4. Reload MFE page
  5. Should see "Accessibility Accommodation Request" in the footer

@KristinAoki KristinAoki merged commit aa13b49 into master Mar 8, 2024
5 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/fix-accessibility-page-link-env-variable branch March 8, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants