feat: migrate enzyme to our react-unit-test-utils #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Syed-Ali-Abbas-Zaidi , thanks for the great PR! I hope we can get the failing tests figured out. Could you rename this PR to "migrate enzyme to react-test-renderer" or "migrate enzyme to our react-unit-test-utils"? Since we are not shifting to RTL here. |
Syed-Ali-Abbas-Zaidi
changed the title
Syed-Ali-Abbas-Zaidi
force-pushed
the
Ali-Abbas/enzyme-to-rtl
branch
from
bc9b4eb
to
8c74b20
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
==========================================
+ Coverage 90.57% 90.61% +0.03%
==========================================
Files 227 228 +1
Lines 4129 4156 +27
Branches 831 842 +11
==========================================
+ Hits 3740 3766 +26
- Misses 369 370 +1
Partials 20 20 ☔ View full report in Codecov by Sentry. |
jesperhodge
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the
enzymeto@edx/react-unit-test-utils.