fix: setAssetToStaticUrl regex matcher #497
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the error of relative asset urls incorrectly rewriting the conversion to the static url. The regex matcher was catching all relative asset url formats:
/assets/courseware/v1/hash/asset-v1:org+num+run+type@asset+block/image.jpeg
/asset-v1:org+num+run+type@asset+block@image.jpeg
/asset-v1:org+num+run+type@asset+block/image.jpeg
This resulted in the first two version rewriting correctly as
/static/image.jpeg
and the third rewriting incorrectly as/static/assetblockimage.jpeg
.Testing
Repeat the steps in the text editor and advanced problem editor. Also, test opening and save existing content for regular problem editor.