fix: useMemo hook removed from JSX, eslint issue ignored

openedx · Aug 10, 2022 · 3730ac2 · 3730ac2
1 parent bb4069b
commit 3730ac2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/react/AppProvider.jsx b/src/react/AppProvider.jsx
@@ -61,13 +61,13 @@ export default function AppProvider({ store, children }) {
     setLocale(getLocale());
   });
 
+  const appContextValue = useMemo(() => ({ authenticatedUser, config, locale }), [authenticatedUser, config, locale]);
+
   return (
     <IntlProvider locale={locale} messages={getMessages()}>
       <ErrorBoundary>
         <AppContext.Provider
-          value={
-            useMemo(() => ({ authenticatedUser, config, locale }), [authenticatedUser, config, locale])
-          }
+          value={appContextValue}
         >
           <OptionalReduxProvider store={store}>
             <Router history={history}>

diff --git a/src/react/PageRoute.jsx b/src/react/PageRoute.jsx
@@ -22,7 +22,8 @@ export default function PageRoute(props) {
     if (match) {
       sendPageEvent();
     }
-  }, [match]);
+  // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [JSON.stringify(match)]);
 
   return (
     <Route {...props} />