fix: wrap ErrorPage with IntlProvider and pass messages #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
force-pushed
the
ags/add-intlprovider-error-page
branch
from
092951e to
0cb10d9
Compare
adamstankiewicz
commented
Aug 1, 2022
| @@ -33,7 +32,7 @@ subscribe(APP_READY, () => { | |||
| }); | |||
|
|
|||
| subscribe(APP_INIT_ERROR, (error) => { | |||
| ReactDOM.render(<IntlProvider><ErrorPage message={error.message} /></IntlProvider>, document.getElementById('root')); | |||
| ReactDOM.render(<ErrorPage message={error.message} />, document.getElementById('root')); | |||
There was a problem hiding this comment.
ErrorPage includes IntlProvider already now.
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
==========================================
+ Coverage 81.24% 81.39% +0.14%
==========================================
Files 38 38
Lines 917 919 +2
Branches 170 170
==========================================
+ Hits 745 748 +3
+ Misses 160 159 -1
Partials 12 12
Continue to review full report at Codecov.
|
pshiu
approved these changes
Aug 2, 2022
long74100
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
ErrorPagerelies on translated messages via react-intl'sFormattedMessagecomponent. However, it currently relies on consumers (i.e., MFEs) to wrapErrorPagewith anIntlProviderand pass alocaleandmessagesprop. Instead, this PR proposes adding anIntlProvidertoErrorPage, pre-configuring itslocaleandmessagesprops from the existing configuration in@edx/frontend-platformvia its initialization.Merge checklist:
frontend-platform. This can be done by runningnpm startand opening http://localhost:8080.module.config.jsfile infrontend-build.fix,feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge: