Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated frontend-build to bump jest version to v27 #513

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jul 12, 2023

Description:

  • Updated frontend-build
  • Fixed failing tests: In Jest v26, "implicit async" allowed test functions to both use the done callback and return a promise. This feature was deprecated in v27, the framework enforces the rule where test functions cannot use both done callback and return a value (promise or otherwise).

Merge checklist:

  • Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
  • Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
  • Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

  • After the build finishes for the merged commit, verify the new release has been pushed to NPM.

@BilalQamar95 BilalQamar95 self-assigned this Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cde921f) 83.05% compared to head (b5f4286) 83.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #513   +/-   ##
=======================================
  Coverage   83.05%   83.05%           
=======================================
  Files          40       40           
  Lines        1062     1062           
  Branches      194      194           
=======================================
  Hits          882      882           
  Misses        168      168           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/frontend-build-jest-upgrade branch from 8690bdb to f551c05 Compare July 14, 2023 11:04
…into bilalqamar95/frontend-build-jest-upgrade
@BilalQamar95 BilalQamar95 changed the title Updated frontend-build to bump jest version to v29 Updated frontend-build to bump jest version to v27 Jul 14, 2023
@BilalQamar95 BilalQamar95 marked this pull request as ready for review July 14, 2023 11:16
…into bilalqamar95/frontend-build-jest-upgrade
…into bilalqamar95/frontend-build-jest-upgrade
@abdullahwaheed abdullahwaheed merged commit 9c11673 into master Jul 17, 2023
@abdullahwaheed abdullahwaheed deleted the bilalqamar95/frontend-build-jest-upgrade branch July 17, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants