docs: adr that outlines tools for enzyme migration #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesperhodge
force-pushed
the
docs--enzyme-deprecation-process-adr
branch
from
4a50c22
to
de17de9
Compare
This was referenced Jun 23, 2023
|
Assigning myself as arbiter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR;
We propose that existing enzyme tests in openedx migrate over to https://github.com/openedx/react-unit-test-utils.
For new tests, we still recommend react-testing-library.
The reason is that it takes much too long and is too risky to migrate directly to react-testing-library, because we would have to rewrite every test file.