feat: Pre-login Exploration Enrolment Handling #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatsnew/src/main/java/org/openedx/whatsnew/presentation/whatsnew/WhatsNewFragment.kt
Outdated
Show resolved
Hide resolved
|
I have started its review 💻 |
omerhabib26
requested changes
Dec 21, 2023
auth/src/main/java/org/openedx/auth/presentation/signup/SignUpViewModel.kt
Show resolved
Hide resolved
discovery/src/main/java/org/openedx/discovery/presentation/DiscoveryViewModel.kt
Outdated
Show resolved
Hide resolved
discovery/src/main/java/org/openedx/discovery/presentation/search/CourseSearchFragment.kt
Show resolved
Hide resolved
discovery/src/main/java/org/openedx/discovery/presentation/DiscoveryRouter.kt
Outdated
Show resolved
Hide resolved
farhan-arshad-dev
requested review from
volodymyr-chekyrta,
omerhabib26 and
k1rill
omerhabib26
previously approved these changes
Dec 26, 2023
| course?.let { | ||
| _uiState.value = CourseDetailsUIState.CourseData( | ||
| course = it, | ||
| isUserLoggedIn = corePreferences.user != null |
There was a problem hiding this comment.
we can use isUserLoggedIn
fixes: LEARNER-9751
- On successfully logging in or registering the user should return to the course about page in the native experience. fixes: LEARNER-9751
- Sticky bottom banner having the register and sign in buttons a they explore discovery without logging in fixes: LEARNER-9751
Fixes: LEARNER-9751
|
Taking on PR responsibilities during Farhan's leave for personal reasons. Ready to handle communication and address queries. |
HamzaIsrar12
force-pushed
the
farhan_ar/LEARNER-9751
branch
from
2c18f1f
to
127880c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-login Exploration Enrolment Handling
Screen_recording_20231218_174011.webm