Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash when trying to get video transcription in main thread #170

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix: crash when trying to get video transcription in main thread #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions course/src/main/java/org/openedx/course/presentation/unit/video/VideoUnitViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import androidx.lifecycle.LifecycleOwner
import androidx.lifecycle.LiveData
import androidx.lifecycle.MutableLiveData
import androidx.lifecycle.viewModelScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.asStateFlow
import kotlinx.coroutines.launch
Expand Down Expand Up @@ -74,9 +75,9 @@ open class VideoUnitViewModel(
}

fun downloadSubtitles() {
viewModelScope.launch {
viewModelScope.launch(Dispatchers.IO) {
transcriptManager.downloadTranscriptsForVideo(getTranscriptUrl())?.let { result ->
_transcriptObject.value = result
_transcriptObject.postValue(result)
timeList = result.captions.values.toList()
.map { it.start.mseconds.toLong() }
}
Expand Down