-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: agreement urls #174
feat: agreement urls #174
Conversation
ef246f7
to
b94df02
Compare
I'm currently reviewing this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @k1rill, Everything is working fine as expected only some minor nits.
Also, I have a couple of inquiries:
1- When altering the app or device language during runtime, the URLs do not undergo any modification or update. Is this intended behavior?
2- Regarding the End User License Agreement (EULA), there appears to be no associated implementation. Should we display it on the Sign-In Page, similar to how it is presented in the edX App?
cc: @moiz994 @marcotuts @volodymyr-chekyrta
profile/src/main/java/org/openedx/profile/presentation/profile/ProfileViewModel.kt
Show resolved
Hide resolved
profile/src/main/java/org/openedx/profile/presentation/profile/ProfileViewModel.kt
Show resolved
Hide resolved
profile/src/main/java/org/openedx/profile/presentation/profile/ProfileUIState.kt
Outdated
Show resolved
Hide resolved
Regarding the EULA link, I need to sync with compliance and Product at 2U to confirm implementation. I can create a separate ticket for this and we can do it in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a minor nit
Configuration fields added:
For
SUPPORTED_LANGUAGES
we are adding lang to the url pathIf configuration field is empty, button will be hided in profile.
telegram-cloud-document-2-5195036426554586834.mp4