Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: agreement urls #174

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

k1rill
Copy link
Contributor

@k1rill k1rill commented Dec 20, 2023

Configuration fields added:

AGREEMENT_URLS:
  PRIVACY_POLICY_URL: ''
  COOKIE_POLICY_URL: ''
  DATA_SELL_CONSENT_URL: ''
  TOS_URL: ''
  EULA_URL: ''
  SUPPORTED_LANGUAGES: [ ] #en is defalut language

For SUPPORTED_LANGUAGES we are adding lang to the url path

If configuration field is empty, button will be hided in profile.

telegram-cloud-document-2-5195036426554586834.mp4

@omerhabib26
Copy link
Contributor

I'm currently reviewing this

@omerhabib26 omerhabib26 self-requested a review December 22, 2023 14:49
Copy link
Contributor

@omerhabib26 omerhabib26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @k1rill, Everything is working fine as expected only some minor nits.
Also, I have a couple of inquiries:
1- When altering the app or device language during runtime, the URLs do not undergo any modification or update. Is this intended behavior?
2- Regarding the End User License Agreement (EULA), there appears to be no associated implementation. Should we display it on the Sign-In Page, similar to how it is presented in the edX App?
cc: @moiz994 @marcotuts @volodymyr-chekyrta

@moiz994
Copy link

moiz994 commented Dec 27, 2023

Hey @k1rill, Everything is working fine as expected only some minor nits. Also, I have a couple of inquiries: 1- When altering the app or device language during runtime, the URLs do not undergo any modification or update. Is this intended behavior? 2- Regarding the End User License Agreement (EULA), there appears to be no associated implementation. Should we display it on the Sign-In Page, similar to how it is presented in the edX App? cc: @moiz994 @marcotuts @volodymyr-chekyrta

Regarding the EULA link, I need to sync with compliance and Product at 2U to confirm implementation. I can create a separate ticket for this and we can do it in a separate PR.

@omerhabib26
Copy link
Contributor

Just need to update the following string to Sentance Case else LGTM 🚀
Screenshot 2024-01-04 at 2 10 00 AM

omerhabib26
omerhabib26 previously approved these changes Jan 3, 2024
Copy link
Contributor

@omerhabib26 omerhabib26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor nit

@volodymyr-chekyrta volodymyr-chekyrta merged commit 591932d into openedx:develop Jan 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Language support for external links in privacy section [Android] FAQ
4 participants