Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added styling to CourseDateBlock #194

Merged
merged 3 commits into from
Jan 25, 2024
Merged

feat: added styling to CourseDateBlock #194

merged 3 commits into from
Jan 25, 2024

Conversation

omerhabib26
Copy link
Contributor

Description

  • Added relative icons for each date type
  • Added locked content description
  • Improve code structuring
  • Improve the time format to understand the remaining time & date better

Issue: 156

@omerhabib26
feat: added styling to CourseDateBlock
354bebb 
- Added relative icons for each date type
- Added locked content description
- Improve code structuring
- Improve time format to better understanding with date

fix: LEARNER-9771
@sdaitzman
Copy link

@omerhabib26 this is looking great, thank you! I noticed two small design issues, hopefully we can resolve these without too much difficulty.

  • The Completed Items collapsible block looks like it has around a 3px border, which should be thinner (1px). I think the thicker border draws a bit too much focus on this screen to that box.
  • The gray subtext for verification-locked items matches the current Figma designs, but on reviewing this screenshot I noticed it looks a bit hard to read. I checked the contrast ratio and found it's too low to meet accessibility guidelines, so we should update this subtext to the Secondary Dark color in light mode. I've updated the designs in Figma to reflect this change.
A screenshot of a contrast ratio checker showing a contrast ratio of 2.49 for the existing labels, which does not pass the WCAG accessibility guidelines

farhan-arshad-dev
farhan-arshad-dev requested changes Jan 23, 2024
View reviewed changes
core/src/main/java/org/openedx/core/data/model/DateType.kt Show resolved Hide resolved
core/src/main/java/org/openedx/core/data/model/DateType.kt Outdated Show resolved Hide resolved
core/src/main/java/org/openedx/core/data/model/DateType.kt Outdated Show resolved Hide resolved
core/src/main/java/org/openedx/core/domain/model/CourseDateBlock.kt Outdated Show resolved Hide resolved
core/src/main/java/org/openedx/core/utils/TimeUtils.kt Show resolved Hide resolved
core/src/main/java/org/openedx/core/utils/TimeUtils.kt Show resolved Hide resolved
course/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/dates/CourseDatesFragment.kt Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/dates/CourseDatesFragment.kt Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/dates/CourseDatesFragment.kt Outdated Show resolved Hide resolved
k1rill
k1rill approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@k1rill k1rill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from my side

volodymyr-chekyrta
volodymyr-chekyrta approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@volodymyr-chekyrta volodymyr-chekyrta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@omerhabib26 omerhabib26 merged commit 5e7cab0 into openedx:develop Jan 25, 2024
3 checks passed
@omerhabib26 omerhabib26 deleted the omer/LEARNER-9771 branch January 25, 2024 09:51
@HamzaIsrar12 HamzaIsrar12 linked an issue Apr 4, 2024 that may be closed by this pull request
[Android] Dates Tab Stylistic Changes #155
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-chekyrta volodymyr-chekyrta volodymyr-chekyrta approved these changes

@farhan-arshad-dev farhan-arshad-dev farhan-arshad-dev approved these changes

@k1rill k1rill k1rill approved these changes

@HamzaIsrar12 HamzaIsrar12 Awaiting requested review from HamzaIsrar12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] Dates Tab Stylistic Changes
5 participants
@omerhabib26 @sdaitzman @k1rill @farhan-arshad-dev @volodymyr-chekyrta