feat: Course Dates Banner #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HamzaIsrar12
requested review from
farhan-arshad-dev,
omerhabib26,
dixidroid,
volodymyr-chekyrta and
k1rill
omerhabib26
requested changes
Jan 22, 2024
course/src/main/java/org/openedx/course/presentation/dates/CourseDatesViewModel.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/dates/CourseDatesViewModel.kt
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/dates/CourseDatesViewModel.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt
Outdated
Show resolved
Hide resolved
omerhabib26
requested changes
Jan 24, 2024
core/src/main/java/org/openedx/core/domain/model/CourseDatesBannerInfo.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/org/openedx/core/domain/model/CourseDatesBannerInfo.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/org/openedx/core/domain/model/CourseDatesBannerInfo.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/org/openedx/core/domain/model/CourseDatesBannerInfo.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/org/openedx/core/domain/model/CourseDatesBannerInfo.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt
Outdated
Show resolved
Hide resolved
omerhabib26
previously approved these changes
Jan 25, 2024
Fixes: LEARNER-9730
HamzaIsrar12
force-pushed
the
hamza/LEARNER-9730
branch
from
0198e8d
to
9bbbbc7
Compare
Fixes: LEARNER-9730
|
Rebased the branch. @omerhabib26 or @k1rill Please re-approve the PR so I can merge it. 👍🏻 |
k1rill
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Course Dates Banner
This pull request displays the course dates banner, leveraging API responses and introducing logic for various scenarios.
The cases are succinctly described as follows:
Note: For instructor-paced courses, the "Upgrade to Graded" case is the sole consideration. The logic for these cases is outlined in the codebase.
Images