Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added PLS banner for shift dates on Course Dashboard #211

Merged
merged 8 commits into from
Feb 7, 2024
Merged

feat: added PLS banner for shift dates on Course Dashboard #211

merged 8 commits into from
Feb 7, 2024

Conversation

omerhabib26
Copy link
Contributor

@omerhabib26 omerhabib26 commented Jan 26, 2024 •
edited
Loading

Description

  • Banner added on course dashboard if its type is RESET_DATES and the course is still accessible.

@omerhabib26
feat: added PLS banner for shift dates on Course Dashboard
48d04e2 
- Banner added on course dashboard if its type is RESET_DATES and course is still available.
k1rill
k1rill requested changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@k1rill k1rill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in all, but I have to request changes because of commented lines

course/src/main/java/org/openedx/course/presentation/container/CourseContainerAdapter.kt Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/container/CourseContainerFragment.kt Outdated Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt Outdated Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt Outdated Show resolved Hide resolved
k1rill
k1rill previously approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@k1rill k1rill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from my side

HamzaIsrar12
HamzaIsrar12 requested changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Points from Manual Review:

  • The 'Shift Due Dates' banner and Snackbar do not disappear after resetting dates from the Course Tab.
  • Please manage the space between resume and dates banner.

core/src/main/java/org/openedx/core/data/api/CourseApi.kt Outdated Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/container/CourseContainerAdapter.kt Outdated Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/container/CourseContainerViewModel.kt Outdated Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/outline/CourseOutlineFragment.kt Outdated Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/outline/CourseOutlineViewModel.kt Outdated Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/outline/CourseOutlineViewModel.kt Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/dates/CourseDatesFragment.kt Show resolved Hide resolved
HamzaIsrar12
HamzaIsrar12 requested changes Feb 1, 2024
View reviewed changes
core/src/main/java/org/openedx/core/data/model/CourseDates.kt Outdated Show resolved Hide resolved
core/src/main/java/org/openedx/core/data/model/CourseDatesBannerInfo.kt Outdated Show resolved Hide resolved
core/src/main/java/org/openedx/core/domain/model/CourseDatesBannerInfo.kt Outdated Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/container/CourseContainerFragment.kt Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/outline/CourseOutlineFragment.kt Outdated Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/outline/CourseOutlineFragment.kt Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/outline/CourseOutlineFragment.kt Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt Show resolved Hide resolved
@volodymyr-chekyrta
Copy link
Contributor

@omerhabib26, could you add a screenshot to show what it looks like when the course photo is displayed?

@omerhabib26
Copy link
Contributor Author

@omerhabib26, could you add a screenshot to show what it looks like when the course photo is displayed?

Added

@omerhabib26 omerhabib26 merged commit a4854e3 into openedx:develop Feb 7, 2024
3 checks passed
@omerhabib26 omerhabib26 deleted the omer/LEARNER-9797 branch February 7, 2024 12:43
@HamzaIsrar12 HamzaIsrar12 linked an issue Apr 4, 2024 that may be closed by this pull request
[Android] Option "Shift due date" #106
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-chekyrta volodymyr-chekyrta volodymyr-chekyrta approved these changes

@HamzaIsrar12 HamzaIsrar12 HamzaIsrar12 approved these changes

@k1rill k1rill k1rill left review comments

@farhan-arshad-dev farhan-arshad-dev Awaiting requested review from farhan-arshad-dev

@dixidroid dixidroid Awaiting requested review from dixidroid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] Option "Shift due date"
4 participants
@omerhabib26 @volodymyr-chekyrta @k1rill @HamzaIsrar12