Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug when sequence units level appear after tapping back #260

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix: bug when sequence units level appear after tapping back #260

merged 1 commit into from
Mar 21, 2024

Conversation

dixidroid
Copy link
Contributor

Removed sequence units level when open a content from Resume or Dates

@dixidroid dixidroid linked an issue Mar 15, 2024 that may be closed by this pull request
[Android] Sequence units level appear after tapping on the "Back" button from Resume action and Dates screens #250
Closed
HamzaIsrar12
HamzaIsrar12 requested changes Mar 17, 2024
View reviewed changes
Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make changes while considering the COURSE_NESTED_LIST_ENABLED flag, accounting for both true and false values.

Previously, it functioned correctly with the false value, but now it operates with the true value. Let's account for both scenarios this time. 😄

@dixidroid
Copy link
Contributor Author

@HamzaIsrar12 so, when COURSE_NESTED_LIST_ENABLED = false when an user clicks the resume button the next content will be opened and then when he goes back the list of units should appear? Don't think this is a good behaviour...thoughts?

@HamzaIsrar12
Copy link
Contributor

@dixidroid
It's a reasonable approach. If it seems incomplete, it might be because we previously highlighted the relevant unit on back press, providing a visual cue for the user to identify the unit they were on.

@dixidroid dixidroid force-pushed the fix/back_from_resume_and_dates branch from 96269ed to 76b6615 Compare March 19, 2024 14:42
@dixidroid
Copy link
Contributor Author

@HamzaIsrar12 I've added an ability to use the COURSE_NESTED_LIST_ENABLED flag

@dixidroid dixidroid force-pushed the fix/back_from_resume_and_dates branch from 76b6615 to 90344a2 Compare March 19, 2024 15:10
HamzaIsrar12
HamzaIsrar12 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏎️ ✨

course/src/main/java/org/openedx/course/presentation/outline/CourseOutlineFragment.kt
@@ -168,14 +168,24 @@ class CourseOutlineFragment : Fragment() {
viewModel.resumeSectionBlock?.let { subSection ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also move this and the other block (in DatesFragment) to their respective ViewModel, but that's up to you now. 😄

@k1rill k1rill merged commit fe76c3d into openedx:develop Mar 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-chekyrta volodymyr-chekyrta volodymyr-chekyrta approved these changes

@HamzaIsrar12 HamzaIsrar12 HamzaIsrar12 approved these changes

@k1rill k1rill k1rill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] Sequence units level appear after tapping on the "Back" button from Resume action and Dates screens
4 participants
@dixidroid @HamzaIsrar12 @k1rill @volodymyr-chekyrta