chore: enhance app theme capability for prod edX theme/branding #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerhabib26
previously approved these changes
Mar 20, 2024
k1rill
previously approved these changes
Mar 22, 2024
|
@farhan-arshad-dev, I see TODO in the description. Also, I see that this PR breaks the Open edX theme by using a secondary button style instead of the primary one.
|
I am currently addressing the design team's feedback. Soon I'll push more appropriate code, that will not break the Openedx theme. |
@farhan-arshad-dev Thank you! 👍 |
farhan-arshad-dev
dismissed stale reviews from k1rill and omerhabib26
via
43a5dd9
farhan-arshad-dev
force-pushed
the
farhan_ar/LEARNER-9783
branch
2 times, most recently
from
43a5dd9
to
e59f589
Compare
|
@volodymyr-chekyrta PR is ready for another pass of review. |
|
Incorrect button color
|
|
Incorrect text field and cursor color
|
|
Incorrect color
|
auth/src/main/java/org/openedx/auth/presentation/signin/compose/SignInView.kt
Outdated
Show resolved
Hide resolved
- Integrate Program config updates - theming/branding code improvements for light and dark modes fixes: LEARNER-9783
farhan-arshad-dev
force-pushed
the
farhan_ar/LEARNER-9783
branch
2 times, most recently
from
b57063e
to
3865e89
Compare
farhan-arshad-dev
force-pushed
the
farhan_ar/LEARNER-9783
branch
from
3865e89
to
926facf
Compare
|
@volodymyr-chekyrta all the comments are addressed, and ready for another pass. |
|
@farhan-arshad-dev, feel free to squash and merge this PR |
PavloNetrebchuk
pushed a commit
to raccoongang/openedx-app-android
that referenced
this pull request
May 30, 2024
…edx#262) chore: enhance app theme capability for prod edX theme/branding - Integrate Program config updates - theming/branding code improvements for light and dark modes - Force dark mode for the WebView (beta version) - No major change in the Open edX theme fixes: LEARNER-9783
volodymyr-chekyrta
added a commit
that referenced
this pull request
Jun 6, 2024
* feat: Course Home progress bar * feat: Collapsing course sections * feat: New download icons * feat: show CourseContainerFragment if COURSE_NESTED_LIST_ENABLED false * fix: course progress bar updating * feat: Renamed COURSE_NESTED_LIST_ENABLE feature flag * feat: Course home. Moved certificate access. * chore: enhance app theme capability for prod edX theme/branding (#262) chore: enhance app theme capability for prod edX theme/branding - Integrate Program config updates - theming/branding code improvements for light and dark modes - Force dark mode for the WebView (beta version) - No major change in the Open edX theme fixes: LEARNER-9783 * feat: [FC-0047] Calendar main screen and dialogs (#322) * feat: Created calendar setting screen * feat: CalendarAccessDialog * feat: NewCalendarDialog * fix: Fixes according to PR feedback * fix: DiscussionTopicsViewModelTest.kt jUnit test * fix: assignment dates * feat: [FC-0047] Improved Dashboard Level Navigation (#308) * feat: Created Learn screen. Added course/program navigation. Added endpoint for UserCourses screen. * feat: Added primary course card * feat: Added start/resume course button * feat: Added alignment items * feat: Fix future assignment date, add courses list, add onSearch and onCourse clicks * feat: Add feature flag for enabling new/old dashboard screen, add UserCoursesScreen onClick methods * feat: Create AllEnrolledCoursesFragment. Add endpoint parameters * feat: AllEnrolledCoursesFragment UI * feat: Minor code refactoring, show cached data if no internet connection * feat: UserCourses screen data caching * feat: Dashboard * refactor: Dashboard type flag change, start course button change * feat: Added programs fragment to LearnFragment viewPager * feat: Empty states and settings button * fix: Number of courses * fix: Minor UI changes * fix: Fixes according to designer feedback * fix: Fixes after demo * refactor: Move CourseContainerTab * fix: Fixes according to PR feedback * fix: Fixes according to PR feedback * feat: added a patch from Omer Habib * fix: Fixes according to PR feedback * fix: Assignment date string * fix: Lint error * fix: Assignment date string * fix: Fixes according to PR feedback * fix: Fixes according to designer feedback * fix: Fixes according to PR feedback --------- Co-authored-by: Volodymyr Chekyrta <volodymyr.chekyrta@raccoongang.com> Co-authored-by: Farhan Arshad <43750646+farhan-arshad-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira: LEARNER-9783, LEARNER-9874
Github issue: [Android] Theming Customization Improvements
Note: No major changes in the OpenEdx Theme.