Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Android Studio Iguana build issues #265

Conversation

volodymyr-chekyrta
Copy link
Contributor

@volodymyr-chekyrta volodymyr-chekyrta commented Mar 20, 2024

This pull request addresses issues that arose following the release of Android Studio Iguana.

Build -> Clean Project problem:
Screenshot 2024-03-20 at 13 50 00

Build -> Rebuild Project problem:
Screenshot 2024-03-20 at 13 49 10

Note: Jetpack Compose tests have been removed due to prolonged lack of maintenance, resulting in compile errors during the build process.

@openedx-webhooks
Copy link

Thanks for the pull request, @volodymyr-chekyrta! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 20, 2024
Copy link
Contributor

@k1rill k1rill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@farhan-arshad-dev farhan-arshad-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting logs

  • java.lang.OutOfMemoryError: Java heap space
  • com.android.tools.r8.CompilationFailedException: Compilation failed to complete
  • java.lang.OutOfMemoryError: Java heap space
Screenshot 2024-03-22 at 3 47 25 PM

@farhan-arshad-dev
Copy link
Contributor

@volodymyr-chekyrta After updating the org.gradle.jvmargs -Xmx2048m -Dfile.encoding=UTF-8 -> -Xmx4608m -Dfile.encoding=UTF-8 in gradle.properties error got fixed, but warnings are still there.

Screenshot 2024-03-22 at 3 55 12 PM

IMO, it's better to consider the warning to be fixed as part of this PR.

@volodymyr-chekyrta
Copy link
Contributor Author

@volodymyr-chekyrta After updating the org.gradle.jvmargs -Xmx2048m -Dfile.encoding=UTF-8 -> -Xmx4608m -Dfile.encoding=UTF-8 in gradle.properties error got fixed, but warnings are still there.

Screenshot 2024-03-22 at 3 55 12 PM IMO, it's better to consider the warning to be fixed as part of this PR.

@farhan-arshad-dev
Yes, I left this issue for future investigation. On my machine that value should be at least -Xmx6144m, so it looks like we'll have to wait for Android Studio to sort it out.

@volodymyr-chekyrta
Copy link
Contributor Author

volodymyr-chekyrta commented Mar 22, 2024

IMO, it's better to consider the warning to be fixed as part of this PR.

@farhan-arshad-dev, this PR concentrates on fixing critical build issues, lets fix warnings in a separate code health PR

@volodymyr-chekyrta volodymyr-chekyrta merged commit cc295d9 into openedx:develop Mar 22, 2024
3 checks passed
@openedx-webhooks
Copy link

@volodymyr-chekyrta 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@volodymyr-chekyrta volodymyr-chekyrta deleted the fix/android_studio_build_issues branch March 22, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants