Code Health: Warnings #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @volodymyr-chekyrta! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
volodymyr-chekyrta
added
the
code health
|
Reviewing |
volodymyr-chekyrta
requested review from
omerhabib26
and removed request for
farhan-arshad-dev and
HamzaIsrar12
omerhabib26
previously approved these changes
Mar 25, 2024
gradle.properties
Outdated
| @@ -21,5 +21,4 @@ kotlin.code.style=official | |||
| # resources declared in the library itself and none from the library's dependencies, | |||
| # thereby reducing the size of the R class for that library | |||
| android.nonTransitiveRClass=true | |||
| android.defaults.buildfeatures.buildconfig=true | |||
| android.nonFinalResIds=false | |||
There was a problem hiding this comment.
please add a line at EOF.
| @@ -395,7 +416,10 @@ fun CommentMainItem( | |||
| .error(org.openedx.core.R.drawable.core_ic_default_profile_picture) | |||
| .placeholder(org.openedx.core.R.drawable.core_ic_default_profile_picture) | |||
| .build(), | |||
| contentDescription = stringResource(id = org.openedx.core.R.string.core_accessibility_user_profile_image, comment.author), | |||
| contentDescription = stringResource( | |||
| id = org.openedx.core.R.string.core_accessibility_user_profile_image, | |||
There was a problem hiding this comment.
please use alias here coreR
| @@ -94,7 +109,10 @@ fun ThreadMainItem( | |||
| .error(org.openedx.core.R.drawable.core_ic_default_profile_picture) | |||
| .placeholder(org.openedx.core.R.drawable.core_ic_default_profile_picture) | |||
| .build(), | |||
| contentDescription = stringResource(id = org.openedx.core.R.string.core_accessibility_user_profile_image, thread.author), | |||
| contentDescription = stringResource( | |||
| id = org.openedx.core.R.string.core_accessibility_user_profile_image, | |||
There was a problem hiding this comment.
please use alias here coreR
| @@ -245,7 +263,10 @@ fun CommentItem( | |||
| .error(org.openedx.core.R.drawable.core_ic_default_profile_picture) | |||
| .placeholder(org.openedx.core.R.drawable.core_ic_default_profile_picture) | |||
| .build(), | |||
| contentDescription = stringResource(id = org.openedx.core.R.string.core_accessibility_user_profile_image, comment.author), | |||
| contentDescription = stringResource( | |||
| id = org.openedx.core.R.string.core_accessibility_user_profile_image, | |||
There was a problem hiding this comment.
please use the alias here coreR
volodymyr-chekyrta
dismissed stale reviews from omerhabib26 and k1rill
via
1c1df99
…ild_warnings # Conflicts: # discussion/src/main/java/org/openedx/discussion/presentation/ui/DiscussionUI.kt
|
@omerhabib26 PR is ready for another pass 🚀 |
omerhabib26
approved these changes
Mar 27, 2024
|
@volodymyr-chekyrta 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR in a series designed to enhance code quality
Other issues will be addressed in a separate PR.