refactor: Enhance calendar event comparison for migration #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhances calendar events comparison for migration by ignoring seconds, and milliseconds improving compatibility with the new codebase. Previously, seconds and milliseconds were not considered. Now, both calendar events and course date blocks have seconds and milliseconds set to zero for precise matching, ensuring a smooth transition. Fixes: LEARNER-9924
HamzaIsrar12
requested review from
omerhabib26,
k1rill,
dixidroid,
farhan-arshad-dev and
volodymyr-chekyrta
volodymyr-chekyrta
approved these changes
Apr 9, 2024
omerhabib26
approved these changes
Apr 15, 2024
k1rill
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances calendar events comparison for migration by ignoring seconds, and milliseconds improving compatibility with the new codebase. Previously, seconds and milliseconds were not considered. Calendar events and course date blocks have seconds and milliseconds set to zero for precise matching, ensuring a smooth transition.