feat: [FC-0047] move the certificate view from the banner to the message section #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @volodymyr-chekyrta! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
volodymyr-chekyrta
force-pushed
the
feature/course_home_certificate
branch
from
4ccad97
to
aa3175d
Compare
volodymyr-chekyrta
added
the
product review
volodymyr-chekyrta
force-pushed
the
feature/course_home_certificate
branch
2 times, most recently
from
5c52a0b
to
31ae726
Compare
|
@HamzaIsrar12 @k1rill, Kindly review the changes made in this pull request. Thank you. |
volodymyr-chekyrta
removed
the
product review
omerhabib26
requested review from
omerhabib26
and removed request for
omerhabib26
HamzaIsrar12
previously approved these changes
May 20, 2024
volodymyr-chekyrta
force-pushed
the
feature/course_home_certificate
branch
from
31ae726
to
4d78460
Compare
|
@volodymyr-chekyrta 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the FC-0047 course home redesign and includes the new certificate message block.
Design:
https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?node-id=14957-309221&t=e1C9Uxns0YlV3sHh-0
Demo:
Changes:
Checklist:
✅ Certificate message appears if the course certificate is earned
✅ A11y. The message block has a big clickable area and works as 1 object for the TalkBack