Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: English plurals error in transifex should be one and other | FC-55 #341

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

OmarIthawi
Copy link
Member

Transifex throws a validation error otherwise.

In other languages Transifex will provide the proper plurals.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 13, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@rnr rnr requested review from k1rill and removed request for rnr June 14, 2024 09:34
@OmarIthawi
Copy link
Member Author

Thanks @volodymyr-chekyrta.

I don't have access to merge the pull request, neither is Brian. Kindly merge it.

cc: @k1rill

@volodymyr-chekyrta volodymyr-chekyrta merged commit dbd02e3 into openedx:develop Jun 15, 2024
3 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants