Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [FC-0047] FCM #344

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

volodymyr-chekyrta
Copy link
Contributor

This pull request introduces Firebase Cloud Messaging (FCM) to the project, enabling the functionality for receiving push notifications from Firebase.

Testing:
• Verified push notifications are received when the app is in the foreground, background, and terminated states.
• Confirmed the app correctly handles notification taps and displays relevant content.
• Ensured token generation and handling work as expected, including handling token refreshes.

Please use the Firebase console for testing; here is a set of all the required fields for navigation:

Notifications:

  1. User has been enrolled
    notification_type: enroll
    course_id: Your course ID (example: course-v1:future+f1+2024)
  2. User has been unenrolled
    notification_type: unenroll
  3. User has been added as a beta tester
    notification_type: add_beta_tester
    course_id: Your course ID (example: course-v1:future+f1+2024)
  4. User has been removed from beta testers
    notification_type: remove_beta_tester
    course_id: Your course ID (example: course-v1:future+f1+2024)
  5. Someone left a response in the user discussion/question
    notification_type: forum_response
    topic_id: Your Topic ID (example: course)
    course_id: Your course ID (example: course-v1:future+f1+2024)
    thread_id: Your thread ID (example: 66584e96f2195c001ad219c7)
    comment_id: Your comment ID (example: 66585c9df2195c001ad219ce)
  6. Someone left a comment in the user discussion/question
    notification_type: forum_comment
    topic_id: Your Topic ID (example: course)
    course_id: Your course ID (example: course-v1:future+f1+2024)
    thread_id: Your thread ID (example: 66583d13f2195c001a56a182)
    parent_id: Your response ID (example: 66586579f2195c001ad219d8)
    comment_id: Your comment ID (example: 6659ac92f2195c001bf37f77)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 18, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @volodymyr-chekyrta! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@volodymyr-chekyrta
Copy link
Contributor Author

@dixidroid @omerhabib26, Kindly review the changes made in this pull request.
Thank you 🙌

@volodymyr-chekyrta volodymyr-chekyrta force-pushed the feature/fcm branch 2 times, most recently from efc1c87 to 7381828 Compare June 18, 2024 10:46
dixidroid
dixidroid previously approved these changes Jun 18, 2024
@dixidroid
Copy link
Contributor

LGTM

dixidroid
dixidroid previously approved these changes Jun 24, 2024
@HamzaIsrar12
Copy link
Contributor

Reviewing ...

Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits only. 👍🏻

@volodymyr-chekyrta
Copy link
Contributor Author

@HamzaIsrar12, thanks for your feedback, PR is ready for the next pass 🚀

Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏎️

@volodymyr-chekyrta volodymyr-chekyrta merged commit 948277a into openedx:develop Jun 25, 2024
4 checks passed
@openedx-webhooks
Copy link

@volodymyr-chekyrta 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants