Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update keyboard visibility and imeAction #350

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

omerhabib26
Copy link
Contributor

@omerhabib26 omerhabib26 commented Jun 24, 2024

Description

  • Hide keyboard on logistration screens
  • update imeAction for long InputEditFields
  • Added errors for empty fields on SignInScreen & Restore Password Screen

-LEARNER-10032

- Hide keyboard on logistration screens
- update imeAction for long InputEditFields

-LEARNER-10032
@omerhabib26 omerhabib26 requested review from k1rill, HamzaIsrar12 and volodymyr-chekyrta and removed request for k1rill June 24, 2024 18:15
- Add error text in case of empty fields on sign in Screen

fix: LEARNER-10032
Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits only

Copy link
Contributor

@volodymyr-chekyrta volodymyr-chekyrta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@volodymyr-chekyrta volodymyr-chekyrta merged commit 5abf44d into openedx:develop Jul 8, 2024
4 checks passed
@omerhabib26 omerhabib26 deleted the omer/LEARNER-10032 branch July 8, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants