-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update keyboard visibility and imeAction #350
Merged
volodymyr-chekyrta
merged 3 commits into
openedx:develop
from
omerhabib26:omer/LEARNER-10032
Jul 8, 2024
Merged
fix: update keyboard visibility and imeAction #350
volodymyr-chekyrta
merged 3 commits into
openedx:develop
from
omerhabib26:omer/LEARNER-10032
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Hide keyboard on logistration screens - update imeAction for long InputEditFields -LEARNER-10032
omerhabib26
requested review from
k1rill,
HamzaIsrar12 and
volodymyr-chekyrta
and removed request for
k1rill
June 24, 2024 18:15
volodymyr-chekyrta
previously approved these changes
Jun 25, 2024
- Add error text in case of empty fields on sign in Screen fix: LEARNER-10032
HamzaIsrar12
requested changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits only
auth/src/main/java/org/openedx/auth/presentation/restore/RestorePasswordFragment.kt
Outdated
Show resolved
Hide resolved
auth/src/main/java/org/openedx/auth/presentation/signin/compose/SignInView.kt
Show resolved
Hide resolved
auth/src/main/java/org/openedx/auth/presentation/signin/compose/SignInView.kt
Outdated
Show resolved
Hide resolved
auth/src/main/java/org/openedx/auth/presentation/signin/compose/SignInView.kt
Outdated
Show resolved
Hide resolved
HamzaIsrar12
approved these changes
Jul 3, 2024
volodymyr-chekyrta
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-LEARNER-10032