Feature/in app review #81
Conversation
# Conflicts: # app/src/main/java/org/openedx/app/di/AppModule.kt
…ted calls on YouTube units. Added AppData(versionName) injection. AppDataHolder is deprecated now.
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @PavloNetrebchuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
PavloNetrebchuk
force-pushed
the
feature/in_app_review
branch
2 times, most recently
from
b092551
to
1f55aaf
Compare
PavloNetrebchuk
force-pushed
the
feature/in_app_review
branch
from
1f55aaf
to
074b975
Compare
# Conflicts: # app/src/main/java/org/openedx/app/di/AppModule.kt # core/src/main/java/org/openedx/core/ui/theme/Color.kt # core/src/main/java/org/openedx/core/ui/theme/Theme.kt # core/src/main/res/values-uk/strings.xml # core/src/main/res/values/strings.xml # course/src/main/java/org/openedx/course/presentation/unit/video/VideoUnitFragment.kt # course/src/main/java/org/openedx/course/presentation/unit/video/YoutubeVideoUnitFragment.kt
PavloNetrebchuk
force-pushed
the
feature/in_app_review
branch
from
8b57ddd
to
a962fee
Compare
PavloNetrebchuk
force-pushed
the
feature/in_app_review
branch
from
d1c6324
to
a42d08b
Compare
# Conflicts: # build.gradle # core/src/main/java/org/openedx/core/ui/theme/Color.kt # core/src/main/java/org/openedx/core/ui/theme/Theme.kt # course/src/main/java/org/openedx/course/presentation/unit/video/VideoFullScreenFragment.kt
PavloNetrebchuk
force-pushed
the
feature/in_app_review
branch
from
a42d08b
to
7a231c1
Compare
|
This looks great to me! It would be ideal to collect feedback directly in-app, but that requires some backend communication and is probably not in-scope for now. |
|
One question:
|
|
@sdaitzman |
|
@PavloNetrebchuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Added in-app review logic:
Show RatingView after the completion of any video.
If the user left negative feedback, choose the "Not Now" option or close the dialog, ask them again after 2 minor or 1 major version.
If the user rated the app from 4 to 5, prompt them to rate it in the Play Store.
If the user rated the app from 1 to 3, prompt them to leave feedback via email.
