Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ora submission created event #335

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Apr 11, 2024

Description

This PR adds an event that should be emitted when a submission is created in ORA

  • Create a new data class:
    • ORASubmissionData
  • Create corresponding signals to process the event:
    • ORA_SUBMISSION_CREATED

Supporting Information

These changes are based on those proposed in the following ADR

@BryanttV BryanttV requested a review from a team as a code owner April 11, 2024 01:37
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 11, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @BryanttV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment: if the event is incompatible with the event bus, we don't need the AVRO schema. Could we remove it? Thanks!

@BryanttV
Copy link
Contributor Author

Hi @mariajgrimaldi, the scheme was removed, thank you!

@BryanttV BryanttV force-pushed the bav/ora-submission-created-event branch from c5700f0 to f61a158 Compare April 11, 2024 22:52
@BryanttV BryanttV force-pushed the bav/ora-submission-created-event branch from f61a158 to 2a0f1a7 Compare April 11, 2024 22:54
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@mariajgrimaldi mariajgrimaldi merged commit c0edbd3 into openedx:main Apr 11, 2024
9 checks passed
@openedx-webhooks
Copy link

@BryanttV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants