Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deleting unused files #155

Merged
merged 2 commits into from
Apr 4, 2024
Merged

chore: deleting unused files #155

merged 2 commits into from
Apr 4, 2024

Conversation

felipemontoya
Copy link
Member

Description: This PR removes some artifacts from the cookie cutter that were never used.

Merge deadline: None. Just cleaning things up

Testing instructions:

  1. check the green marks from the CI build. If it passes, then this files are not needed at all.

Author concerns: Could something in the CI break if this file is not present?

@felipemontoya felipemontoya requested a review from a team as a code owner April 4, 2024 19:53
@openedx-webhooks
Copy link

Thanks for the pull request, @felipemontoya! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 4, 2024
Copy link
Contributor

@Ian2012 Ian2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipemontoya felipemontoya merged commit 8f7d94f into main Apr 4, 2024
8 checks passed
@felipemontoya felipemontoya deleted the fmo/test_dir branch April 4, 2024 23:53
@openedx-webhooks
Copy link

@felipemontoya 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants