Fix make upgrade job #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UsamaSadiq
commented
Oct 3, 2022
aht007
approved these changes
Oct 3, 2022
requirements/common_constraints.txt
Outdated
Comment on lines
1
to
27
| # A central location for most common version constraints | ||
| # (across edx repos) for pip-installation. | ||
| # | ||
| # Similar to other constraint files this file doesn't install any packages. | ||
| # It specifies version constraints that will be applied if a package is needed. | ||
| # When pinning something here, please provide an explanation of why it is a good | ||
| # idea to pin this package across all edx repos, Ideally, link to other information | ||
| # that will help people in the future to remove the pin when possible. | ||
| # Writing an issue against the offending project and linking to it here is good. | ||
| # | ||
| # Note: Changes to this file will automatically be used by other repos, referencing | ||
| # this file from Github directly. It does not require packaging in edx-lint. | ||
|
|
||
|
|
||
| # using LTS django version | ||
| Django<4.0 | ||
|
|
||
| # elasticsearch>=7.14.0 includes breaking changes in it which caused issues in discovery upgrade process. | ||
| # elastic search changelog: https://www.elastic.co/guide/en/enterprise-search/master/release-notes-7.14.0.html | ||
| elasticsearch<7.14.0 | ||
|
|
||
| # setuptools==60.0 had breaking changes and busted several service's pipeline. | ||
| # Details can be found here: https://github.com/pypa/setuptools/issues/2940 | ||
| setuptools<60 | ||
|
|
||
| # django-simple-history>3.0.0 adds indexing and causes a lot of migrations to be affected | ||
| django-simple-history==3.0.0 |
There was a problem hiding this comment.
I'm checking now the cookie cutter & they do this: https://github.com/openedx/edx-cookiecutters/blob/master/python-template/{{cookiecutter.placeholder_repo_name}}/requirements/constraints.txt#L12
why don't we do that?
There was a problem hiding this comment.
We had used this approach in some repos where we needed to override a constraint from global constraints. Updated the logic according to the cookie cutters template now since that situation is not applicable here.
UsamaSadiq
force-pushed
the
fix-make-upgrade-job
branch
from
2d10179
to
c38371f
Compare
mariajgrimaldi
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description